Convert to GHA, fix tests, fix build #388
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #388 +/- ##
==========================================
Coverage ? 93.65%
Complexity ? 1590
==========================================
Files ? 102
Lines ? 4743
Branches ? 828
==========================================
Hits ? 4442
Misses ? 286
Partials ? 15 |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
MrCreosote
changed the title
| - "tcp://ci-mongo:27017" | ||
| - "-wait" | ||
| - "tcp://mongoinit:8080" | ||
| - "tcp://mongo:27017" | ||
| - "-timeout" | ||
| - "120s" | ||
| - "-template" |
There was a problem hiding this comment.
If my understanding is correct,
a line starts with "-" is an arg, and then followed by its val? For instance, "-timeout", "120s"
What are "java" and "-Djetty.home=/usr/local/jetty" then?
There was a problem hiding this comment.
"-" is an arg, and then followed by its val?
Not always, one example is -multiline
The first set of arguments are for dockerize. Then there's the command that dockerize will run, java, and its arguments.
There was a problem hiding this comment.
among these args, which are for docker and which are for java programs?
There was a problem hiding this comment.
everything after java are the java args
There was a problem hiding this comment.
what about -template? I did not find this arg in docker-compose up -h
There was a problem hiding this comment.
the arguments are for dockerize, not docker-compose
There was a problem hiding this comment.
I see. May I know which line it pull dockerize image? Cannot find it anywhere.
There was a problem hiding this comment.
It doesn't, dockerize is built into the base image
There was a problem hiding this comment.
I found it. is here:
|3 BRANCH=master BUILD_DATE=2018-11-08T20:13:52Z VCS_REF=bb0c445 /bin/sh -c mkdir -p /var/lib/apt/lists/partial && apt-get update -y && apt-get install -y ca-certificates tomcat8-user libservlet3.1-java && update-ca-certificates && useradd -c "KBase user" -rd /kb/deployment/ -u 998 -s /bin/bash kbase && mkdir -p /kb/deployment/bin && mkdir -p /kb/deployment/jettybase/logs/ && touch /kb/deployment/jettybase/logs/request.log && chown -R kbase /kb/deployment && cd /kb/deployment/bin && wget -N https://github.com/kbase/dockerize/raw/master/dockerize-linux-amd64-v0.6.1.tar.gz && tar xvzf dockerize-linux-amd64-v0.6.1.tar.gz && rm dockerize-linux-amd64-v0.6.1.tar.gz
No description provided.